Adding in SQL commands to prepare an instance to join an existing shard#4528
Merged
sougou merged 1 commit intovitessio:masterfrom Jan 16, 2019
Merged
Adding in SQL commands to prepare an instance to join an existing shard#4528sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Dan Kozlowski <koz@planetscale.com>
sougou
approved these changes
Jan 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with MariaDB 10.3 joining an existing shard. There appears to be existing transactions in the binlog from the database being initialized. These prevent the new instance from joining the shard. This PR adds additional commands to RESET replication before the database starts. This should only run when the system detects an empty database.
Signed-off-by: Dan Kozlowski koz@planetscale.com